Prevent the intellifire client from polling independently of its coordinator by jeeftor · Pull Request #165341 · home-assistant/core

jeeftor · 2026-03-11T17:58:23Z

Proposed change

In the current mode of operation Home Assistant issues a change request to the fireplace via the backing library, then waits until the next coordinator poll to pick up the new state. Meanwhile the backing library is also running its own internal polling loop, resulting in duplicate polls and slower responsiveness.

This PR fixes that by:

Passing polling_enabled=False when constructing the UnifiedFireplace, disabling the library's internal polling loop
Calling perform_poll() directly from the coordinator's _async_update_data(), so HA controls all polling

The required library changes (perform_poll() and polling_enabled flag) landed in intellifire4py==4.4.0, which was bumped in the preliminary PR #165356.

see: Possible double polling loop when used in HA leading to inconsistent (and long) update times jeeftor/intellifire4py#238

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue:
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
New or updated dependencies have been added to requirements_all.txt.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

zxdavb

Some suggestions for you.

zxdavb · 2026-03-11T20:16:38Z

Could you have this as release note on the client repo, and link to that from here?

Summary of Changes to Backing Lib
Added optional background_polling flag to UnifiedFireplace constructor to disable the library's internal polling loop
Added a perform_poll / poll() method to UnifiedFireplace that delegates to the appropriate local or cloud API

Copilot

Pull request overview

Updates the IntelliFire integration to rely on Home Assistant’s coordinator-driven polling rather than the intellifire4py client polling independently, improving responsiveness after state changes.

Changes:

Bump intellifire4py dependency from 4.3.1 to 4.4.0.
Disable library-side polling at fireplace construction time and trigger polling from the coordinator (perform_poll()).
Add/extend tests and mocks to validate coordinator-driven polling behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`homeassistant/components/intellifire/__init__.py`	Passes a flag to disable library polling when constructing the `UnifiedFireplace`.
`homeassistant/components/intellifire/coordinator.py`	Calls `fireplace.perform_poll()` during coordinator refresh to explicitly drive polling.
`homeassistant/components/intellifire/manifest.json`	Pins integration requirement to `intellifire4py==4.4.0`.
`requirements_all.txt`	Updates global pin for `intellifire4py` to `4.4.0`.
`requirements_test_all.txt`	Updates test pin for `intellifire4py` to `4.4.0`.
`tests/components/intellifire/conftest.py`	Extends the fireplace mock to include `perform_poll`.
`tests/components/intellifire/test_init.py`	Adds tests asserting coordinator-driven polling and polling-disabled construction.

You can also share your feedback on Copilot code review. Take the survey.

zxdavb · 2026-03-11T20:37:49Z

Please address Copilot's points- mark them/mine as resolved, and re-request review from me when you're ready.

epenet

Can the library bkmp be done in a preliminary PR?

jeeftor · 2026-03-11T21:20:18Z

@epenet - > YES IT CAN!

(once merged I'll rebase this PR)
#165356

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Test seems to be good now

…dinator (#165341) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Robert Resch <robert@resch.dev> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jeeftor changed the title ~~double polling~~ BugFix: Intellifire - Double Polling Mar 11, 2026

jeeftor force-pushed the feature/intellifire_double_poll_v2 branch from 76fcaec to e6f8c22 Compare March 11, 2026 18:21

home-assistant Bot added the cla-signed label Mar 11, 2026

zxdavb reviewed Mar 11, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py Outdated

zxdavb reviewed Mar 11, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py Outdated

zxdavb reviewed Mar 11, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py Outdated

zxdavb previously requested changes Mar 11, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py Outdated

zxdavb changed the title ~~BugFix: Intellifire - Double Polling~~ Prevent the intellifire client from polling independently of its coordinator Mar 11, 2026

zxdavb added bugfix integration: intellifire labels Mar 11, 2026

home-assistant Bot added by-code-owner Quality Scale: No score labels Mar 11, 2026

zxdavb added the has-tests label Mar 11, 2026

jeeftor marked this pull request as ready for review March 11, 2026 20:29

Copilot AI review requested due to automatic review settings March 11, 2026 20:29

Copilot started reviewing on behalf of jeeftor March 11, 2026 20:30 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py Outdated

Comment thread homeassistant/components/intellifire/__init__.py

Comment thread tests/components/intellifire/test_init.py Outdated

Comment thread tests/components/intellifire/test_init.py

epenet reviewed Mar 11, 2026

View reviewed changes

jeeftor mentioned this pull request Mar 11, 2026

Bump intellifire4py to 4.4.0 #165356

Merged

21 tasks

jeeftor and others added 5 commits March 12, 2026 08:19

double polling

1a05780

address PR comments

81ff841

Fix test docstring to avoid referencing the PR context

49640da

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pushing changes

b12449b

Use assert_awaited_once() for AsyncMock assertions in intellifire tests

2bfd2e8

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 12, 2026 14:20

jeeftor force-pushed the feature/intellifire_double_poll_v2 branch from 01fe66a to 2bfd2e8 Compare March 12, 2026 14:20

Copilot started reviewing on behalf of jeeftor March 12, 2026 14:20 View session

Copilot AI review requested due to automatic review settings April 1, 2026 12:40

Copilot started reviewing on behalf of jeeftor April 1, 2026 12:41 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py

addressign pr comments

564a033

jeeftor marked this pull request as ready for review April 1, 2026 12:55

Copilot AI review requested due to automatic review settings April 1, 2026 12:56

home-assistant Bot requested review from edenhaus and zxdavb April 1, 2026 12:56

Copilot started reviewing on behalf of jeeftor April 1, 2026 12:56 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Comment thread tests/components/intellifire/test_init.py Outdated

jeeftor marked this pull request as draft April 1, 2026 15:28

copilot chnages

758e958

jeeftor marked this pull request as ready for review April 1, 2026 15:36

Copilot AI review requested due to automatic review settings April 1, 2026 15:36

Copilot started reviewing on behalf of jeeftor April 1, 2026 15:37 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

jeeftor requested review from Copilot and epenet April 8, 2026 18:51

Copilot started reviewing on behalf of jeeftor April 8, 2026 18:52 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

joostlek approved these changes Apr 9, 2026

View reviewed changes

joostlek added this to the 2026.4.2 milestone Apr 9, 2026

joostlek merged commit 1e78666 into home-assistant:dev Apr 9, 2026
39 of 41 checks passed

frenck added the cherry-picked label Apr 10, 2026

frenck mentioned this pull request Apr 10, 2026

2026.4.2 #167939

Merged

github-actions Bot locked and limited conversation to collaborators Apr 11, 2026

jeeftor deleted the feature/intellifire_double_poll_v2 branch April 21, 2026 18:58

Uh oh!

Conversation

jeeftor commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zxdavb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zxdavb commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zxdavb commented Mar 11, 2026

Uh oh!

epenet left a comment

Choose a reason for hiding this comment

Uh oh!

jeeftor commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jeeftor commented Mar 11, 2026 •

edited

Loading